From d4a97f0962fab70a486e17f8b8770fbaabe51e0f Mon Sep 17 00:00:00 2001 From: "Rong \"Mantle\" Bao" Date: Thu, 13 Jul 2023 08:38:11 +0800 Subject: [PATCH] fix: fix inconsistent queryPath accross routes --- src/common/__tests__/queryPath.test.ts | 8 ++++---- src/common/queryPath.ts | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/common/__tests__/queryPath.test.ts b/src/common/__tests__/queryPath.test.ts index a5b2c8f..540051a 100644 --- a/src/common/__tests__/queryPath.test.ts +++ b/src/common/__tests__/queryPath.test.ts @@ -63,9 +63,9 @@ describe("queryPath", () => { id: 1, }, ] as const - expect(queryPath(null, 1)).toStrictEqual("#") - expect(queryPath(undefined, 1)).toStrictEqual("#") - expect(queryPath([], 1)).toStrictEqual("#") - expect(queryPath(routes, 1)).toStrictEqual("#") + expect(queryPath(null, 1)).toStrictEqual("") + expect(queryPath(undefined, 1)).toStrictEqual("") + expect(queryPath([], 1)).toStrictEqual("") + expect(queryPath(routes, 1)).toStrictEqual("") }) }) diff --git a/src/common/queryPath.ts b/src/common/queryPath.ts index 23781be..304c324 100644 --- a/src/common/queryPath.ts +++ b/src/common/queryPath.ts @@ -26,7 +26,7 @@ export type TRoutes = readonly TRoute[] | null | undefined export const queryPath = memoize( (routes: TRoutes, id: number): string => { - return head(filter(routes, (r) => r?.id === id))?.path ?? "#" + return head(filter(routes, (r) => r?.id === id))?.path ?? "" }, - (_, id) => id + (routes, id) => [routes, id] )