Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip spaces on registration and refine password reset #1218

Merged
merged 1 commit into from Jan 20, 2020

Conversation

ColdHeat
Copy link
Member

  • Usernames are now properly stripped before being used in registration checks
  • Reset password function now uses email addresses instead of user names for tokens
  • Prevent MLC users from resetting their password

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #1218 into master will decrease coverage by 0.02%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
- Coverage    88.4%   88.37%   -0.03%     
==========================================
  Files          97       97              
  Lines        5219     5232      +13     
==========================================
+ Hits         4614     4624      +10     
- Misses        605      608       +3
Impacted Files Coverage Δ
CTFd/schemas/teams.py 81.55% <100%> (+0.18%) ⬆️
CTFd/schemas/users.py 95.91% <100%> (+0.08%) ⬆️
CTFd/utils/email/__init__.py 91.42% <100%> (+0.51%) ⬆️
CTFd/teams.py 96.22% <100%> (ø) ⬆️
CTFd/auth.py 89.02% <85%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe85fdf...0e0b48b. Read the comment docs.

@ColdHeat ColdHeat merged commit f660ed1 into master Jan 20, 2020
@ColdHeat ColdHeat deleted the strip-spaces-registration branch January 20, 2020 19:22
@stefan2904
Copy link

This is now CVE-2020-7245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants