Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs/issue 68 int 16 too small #69

Merged
merged 6 commits into from
Oct 8, 2016
Merged

Conversation

drnlm
Copy link
Member

@drnlm drnlm commented Oct 8, 2016

This should fix #68

We're not completely pygame compatible, since we handle values greater than 2**32 differently. I hope the chances of anyone depending on that behaviour are small that we can ignore that, becuase matching that behaviour will be ugly.

Copy link
Member

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a pygame compatibility test for these overflow cases?

sdlrect.x = start_x
sdlrect.y = y
sdlrect.w = end_x - start_x + 1
sdlrect.x = ffi.cast("int16_t",start_x)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after comma.

@drnlm drnlm merged commit ce6bb6d into master Oct 8, 2016
@drnlm drnlm deleted the bugs/issue-68-int_16_too_small branch October 8, 2016 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverflowError: integer 32769 does not fit 'int16_t'
2 participants