Merged
Conversation
added 4 commits
October 8, 2016 15:59
…nd drawvertline PyGame casts when calling these functions, but this seems a saner idea.
hodgestar
requested changes
Oct 8, 2016
Member
hodgestar
left a comment
hodgestar
left a comment
There was a problem hiding this comment.
Could we add a pygame compatibility test for these overflow cases?
| sdlrect.x = start_x | ||
| sdlrect.y = y | ||
| sdlrect.w = end_x - start_x + 1 | ||
| sdlrect.x = ffi.cast("int16_t",start_x) |
hodgestar
approved these changes
Oct 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #68
We're not completely pygame compatible, since we handle values greater than 2**32 differently. I hope the chances of anyone depending on that behaviour are small that we can ignore that, becuase matching that behaviour will be ugly.