Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for pygame.math. #74
I left a bunch of small comments. Generally looking like a good start though!
There are a few discrepencies between pygame and our behaviour that need to be either fixed or documented, but overall this looks really good.
I've left a couple of additional comments, but in general looks awesome.
There are quite a few places where we might we able to speed things up considerably by avoiding the property look up for
vec.x, vec.y, vec.z but I think that is best tackled in a separate branch later if we want to (we can either carefully use
_x a lot, or we can remove
_x and try use just a setter for
x without a getter -- which is a bit fiddly to arrange, but doable).