Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submitting a talk review via the talk page may update the talk status without creating a revision. #608

Closed
hodgestar opened this issue Jul 13, 2021 · 1 comment
Closed

Submitting a talk review via the talk page may update the talk status without creating a revision. #608

hodgestar opened this issue Jul 13, 2021 · 1 comment

Comments

@hodgestar
Copy link
Member

hodgestar commented Jul 13, 2021

In TalkReview.form_valid the talk status is updated if a first review is added and the talk is not yet under review, but no talk revision is created for the update.

This doesn't break anything, but creates a confusing gap in the talk revision audit trail.
This was referenced Oct 9, 2021
Merged
Merged
@drnlm
Copy link
Member

drnlm commented Oct 10, 2021

Fixed by #626

@drnlm drnlm closed this as completed Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hodgestar @drnlm