-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 1.10 support #276
Django 1.10 support #276
Conversation
Django rest framework gained support for Django 1.10 with encode/django-rest-framework#4158 , but that hasn't made it into a release yet. |
Since we've dropped support for Django 1.7, and django-restframework has had a release supporting 1.10, we should resume looking at this. |
Found a new PR to subscribe to, which is blocking this one: zsiciarz/django-markitup#19 Though there is some tidying up I can still do for the namespacing stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably to explicitly test whether the DJANGO_VERSION string is pointing to master, rather than trying to come up with a pip command that handles both cases
Since Ubuntu won't have bash built with regex command, some hack along the lines of
if [ "${DJANGO_VERSION/master/" != "$DJANGO_VERSION" ]; then
# Django master
pip install $DJANGO_VERSION
else
# Numeric version
pip install 'Django=~'"$DJANGO_VERSION"
fi```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
before_install: | ||
- if [ "$TESTDB" = "postgres" ]; then pip install -q psycopg2 ; fi | ||
# command to install dependencies, | ||
install: | ||
# Install the right version of Django first | ||
- pip install 'Django~='"$DJANGO_VERSION".0 | ||
- pip install $DJANGO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to have complicated things in $DJANGO
, it should probably be quoted here.
The one Travis run is trying to build CTPUG's django 1.10 branch instead of my fork's branch. |
PR for tracking support for Django 1.10
django.conf.urls.pattern
has been removedneed to come back)