New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.10 support #276

Merged
merged 10 commits into from Oct 17, 2016

Conversation

Projects
None yet
3 participants
@zoidbergwill
Contributor

zoidbergwill commented Jul 11, 2016

PR for tracking support for Django 1.10

  • django.conf.urls.pattern has been removed
  • checking namespace/app_name patterns stuff still works (I blindly deleted lines that might
    need to come back)
  • django rest framework issue:
Unhandled exception in thread started by <function check_errors.<locals>.wrapper at 0x102796158>
  File "/src/git/ctpug/wafer/wafer/users/urls.py", line 14, in <module>
    url(r'^api/', include(router.urls)),
  File "/src/git/ctpug/wafer/virtualenv/lib/python3.5/site-packages/rest_framework/routers.py", line 79, in urls
    self._urls = self.get_urls()
  File "/src/git/ctpug/wafer/virtualenv/lib/python3.5/site-packages/rest_framework/routers.py", line 321, in get_urls
    urls = format_suffix_patterns(urls)
  File "/src/git/ctpug/wafer/virtualenv/lib/python3.5/site-packages/rest_framework/urlpatterns.py", line 64, in format_suffix_patterns
    return apply_suffix_patterns(urlpatterns, suffix_pattern, suffix_required)
  File "/src/git/ctpug/wafer/virtualenv/lib/python3.5/site-packages/rest_framework/urlpatterns.py", line 27, in apply_suffix_patterns
    view = urlpattern._callback or urlpattern._callback_str
AttributeError: 'RegexURLPattern' object has no attribute '_callback'
@drnlm

This comment has been minimized.

Member

drnlm commented Jul 11, 2016

Django rest framework gained support for Django 1.10 with encode/django-rest-framework#4158 , but that hasn't made it into a release yet.

@drnlm

This comment has been minimized.

Member

drnlm commented Aug 16, 2016

Since we've dropped support for Django 1.7, and django-restframework has had a release supporting 1.10, we should resume looking at this.

@zoidbergwill

This comment has been minimized.

Contributor

zoidbergwill commented Aug 20, 2016

Found a new PR to subscribe to, which is blocking this one: zsiciarz/django-markitup#19

Though there is some tidying up I can still do for the namespacing stuff.

@zoidbergwill zoidbergwill force-pushed the zoidbergwill:django-1.10 branch 2 times, most recently from df04461 to 147631a Oct 8, 2016

@drnlm

We probably to explicitly test whether the DJANGO_VERSION string is pointing to master, rather than trying to come up with a pip command that handles both cases

Since Ubuntu won't have bash built with regex command, some hack along the lines of


if [ "${DJANGO_VERSION/master/" != "$DJANGO_VERSION" ]; then
   # Django master
   pip install $DJANGO_VERSION
else
  # Numeric version
   pip install 'Django=~'"$DJANGO_VERSION"
fi```
@drnlm

drnlm approved these changes Oct 9, 2016

👍

.travis.yml Outdated
before_install:
- if [ "$TESTDB" = "postgres" ]; then pip install -q psycopg2 ; fi
# command to install dependencies,
install:
# Install the right version of Django first
- pip install 'Django~='"$DJANGO_VERSION".0
- pip install $DJANGO

This comment has been minimized.

@hodgestar

hodgestar Oct 9, 2016

Member

If we're going to have complicated things in $DJANGO, it should probably be quoted here.

@zoidbergwill zoidbergwill changed the title from [WIP] Django 1.10 support to Django 1.10 support Oct 13, 2016

zoidbergwill added some commits Jul 11, 2016

@zoidbergwill zoidbergwill force-pushed the zoidbergwill:django-1.10 branch from 3b77624 to 340193b Oct 13, 2016

@zoidbergwill

This comment has been minimized.

Contributor

zoidbergwill commented Oct 17, 2016

The one Travis run is trying to build CTPUG's django 1.10 branch instead of my fork's branch.

@zoidbergwill zoidbergwill merged commit 7388b22 into CTPUG:master Oct 17, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zoidbergwill zoidbergwill deleted the zoidbergwill:django-1.10 branch Oct 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment