Bump to Bootstrap 4 #310
Merged
Bump to Bootstrap 4 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of this is in: https://v4-alpha.getbootstrap.com/migration/ Otherwise I viewed source for the docs to do some of it.
zoidbergwill
force-pushed
the
bootstrap-4
branch
2 times, most recently
from
e886bc5
to
3d2f165
Compare
drnlm
reviewed
Oct 9, 2016
| "bootstrap": "^4.0.0-alpha.4" | ||
| }, | ||
| "scripts": { | ||
| "postinstall" : "rm -rf wafer/static/vendor/ && mkdir wafer/static/vendor/ && rsync -a node_modules/* wafer/static/vendor/" |
There was a problem hiding this comment.
Wouldn't using rsync --del and mkdir -p achieve the same result and be a bit shorter?
There was a problem hiding this comment.
Awesome, TIL --del is a thing.
drnlm
requested changes
Oct 9, 2016
|
Agreed. Updating the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Using
npmtriggers/hooks/scripts sucks, but cleaner/tidier than using a script to wrap it all.Now comes the actual migration