New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Bootstrap 4 #310

Merged
merged 5 commits into from Oct 13, 2016

Conversation

Projects
None yet
2 participants
@zoidbergwill
Contributor

zoidbergwill commented Oct 9, 2016

Using npm triggers/hooks/scripts sucks, but cleaner/tidier than using a script to wrap it all.

Now comes the actual migration

zoidbergwill added some commits Oct 9, 2016

Nav CSS classes have changed a bit in bootstrap too
Some of this is in: https://v4-alpha.getbootstrap.com/migration/

Otherwise I viewed source for the docs to do some of it.

@zoidbergwill zoidbergwill force-pushed the bootstrap-4 branch 2 times, most recently from e886bc5 to 3d2f165 Oct 9, 2016

"bootstrap": "^4.0.0-alpha.4"
},
"scripts": {
"postinstall" : "rm -rf wafer/static/vendor/ && mkdir wafer/static/vendor/ && rsync -a node_modules/* wafer/static/vendor/"

This comment has been minimized.

@drnlm

drnlm Oct 9, 2016

Member

Wouldn't using rsync --del and mkdir -p achieve the same result and be a bit shorter?

This comment has been minimized.

@zoidbergwill

zoidbergwill Oct 9, 2016

Contributor

Awesome, TIL --del is a thing.

@drnlm

If we're dropping bower, we need to update the install instructions in the README to reflect this.

Otherwise, looks OK.

@zoidbergwill

This comment has been minimized.

Contributor

zoidbergwill commented Oct 9, 2016

Agreed. Updating the README.

@drnlm

drnlm approved these changes Oct 9, 2016

👍

@zoidbergwill zoidbergwill changed the title from [WIP] Bump to Bootstrap 4 to Bump to Bootstrap 4 Oct 13, 2016

@zoidbergwill zoidbergwill merged commit ad74fe5 into master Oct 13, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zoidbergwill zoidbergwill deleted the bootstrap-4 branch Oct 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment