Add a management command to load pages from markdown pages on disk#314
Merged
Conversation
drnlm
requested changes
Oct 9, 2016
Member
drnlm
left a comment
drnlm
left a comment
There was a problem hiding this comment.
Some documentation about the format, or more help about the format, would be nice, but otherwise seems fine.
hodgestar
reviewed
Nov 8, 2016
|
|
||
| /app/pages/ ← PAGE_DIR | ||
| /app/pages/index.md ← Home Page: / | ||
| /app/pages/about.md ← Container Page: /about/ |
Member
There was a problem hiding this comment.
It seems a bit more natural for this to be /app/pages/about/index.md?
Member
Author
There was a problem hiding this comment.
Yes, it does. But that doesn't match how we actually render pages. The root index page is a hack. This closely mirrors the DB structure.
Member
There was a problem hiding this comment.
Although that doesn't match Wafer's internals that well. Happy for you to make a choice on this.
hodgestar
reviewed
Nov 8, 2016
|
|
||
| Pages must be stored as markdown in a directory, in the same hierarchy | ||
| as the desired URL structure. | ||
| The ``PAGE_DIR`` setting should be an absolute path to root directory of this |
Member
There was a problem hiding this comment.
I would say Django setting here just to be clearer that this lives in settings.py.
Member
|
Looks good to me. |
drnlm
approved these changes
Nov 10, 2016
Fixes: #150. Mostly. Without locking pages, as that probably isn't necessary for now. Pages are layed out matching the URL structure, with jekyll-style front matter to describe metadata.
stefanor
force-pushed
the
pages-in-git
branch
from
65b5de1 to
91b9b24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #150. Mostly. Without locking pages, as that probably isn't
necessary for now.
Pages are layed out matching the URL structure, with jekyll-style front
matter to describe metadata.
Not declaring a pyyaml dependency, as it's only needed in this management command, and thus rather optional.