Add API endpoints for adding, removing and updating talk URLs#316
Merged
Conversation
Member
Author
|
Ready for review. |
drnlm
reviewed
Oct 9, 2016
Member
drnlm
left a comment
drnlm
left a comment
There was a problem hiding this comment.
A couple of notes, but otherwise looks good.
| talk_a = create_talk("Talk A", ACCEPTED, "author_a") | ||
| talk_b = create_talk("Talk B", REJECTED, "author_b") | ||
| response = self.client.get('/talks/api/talks/') | ||
| result_0, result_1 = response.data['results'] |
Member
There was a problem hiding this comment.
Why are we splitting this if we're then testing response.data['results'] directly?
Member
Author
There was a problem hiding this comment.
I've removed these unused variables. :)
| url_b = TalkUrl.objects.create( | ||
| talk=talk, url="http://b.example.com/", description="slides") | ||
| response = self.client.get('/talks/api/talks/%d/urls/' % talk.talk_id) | ||
| result_0, result_1 = response.data['results'] |
| def generic(self, *args, **kw): | ||
| response = super(SortedResultsClient, self).generic(*args, **kw) | ||
| return self._sorted_response(response) | ||
|
|
Member
There was a problem hiding this comment.
This isn't terrible specific to talks - should we move it to a test_utils module so it can be used when testing other apis?
Member
Author
There was a problem hiding this comment.
I moved it into wafer.tests.api_utils. It'll likely need to grow some features once we start writing tests for other parts of the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the following API end points:
/talks/api/talks/<talk_id>/urls//talks/api/talks/<talk_id>/urls/<url_id>/If also adds a summary of the URLs to the data returned when querying the talks API.