Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit every SQL for logging #12

Closed
kadishmal opened this issue Jan 7, 2015 · 1 comment
Closed

Emit every SQL for logging #12

kadishmal opened this issue Jan 7, 2015 · 1 comment
Assignees
@kadishmal
Labels
enhancement
Milestone
3.0.0

Comments

@kadishmal
Copy link
Contributor

For clients to log particular SQLs if necessary, we should emit every SQL. For convenience, we can categorize events such as 'query' and execute, or read and write.

This functionality can overlap with #11. Perhaps we need to keep this one and close #11.
@kadishmal kadishmal modified the milestone: 2.2.1 Jan 7, 2015
@kadishmal kadishmal changed the title Emit every SQL Emit every SQL for logging Jan 7, 2015
@kadishmal kadishmal modified the milestones: 2.2.1, 2.2.2 Feb 1, 2015
@kadishmal kadishmal modified the milestones: 2.2.2, 2.3.0 Mar 11, 2015
@kadishmal
Copy link
Contributor Author

kadishmal commented Sep 29, 2016 •
edited

Instead of emitting, we now accept logger argument and log via that object. Closing this issue as it is resolved via #11.

@kadishmal kadishmal added this to the 3.0.0 milestone Sep 29, 2016
@kadishmal kadishmal self-assigned this Sep 29, 2016
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#49 Implement Protocol v6 of CUBRID.
99dde5f 
New Features

#49 Implement Protocol v6 of CUBRID.
#13 Add support for alternative hosts to support client side HA.
#12 #11 Provide a configurable logging function.
#18 Added ENUM data type support via the old protocol.
#14 Support promises.
Refactoring

#48 Update README.
#14 Indent using spaces instead of tabs.
#14 Reduce the use of self where this can be used directly.
#14 Extract constants and other useless variables from the connection
object.
@kadishmal kadishmal mentioned this issue Oct 5, 2016
Merged
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
Merge pull request #50 from CUBRID/14
4643ab1 
Closes #49, #11, #12, #13, #14, #48 Implement Protocol v6 of CUBRID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kadishmal kadishmal

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@kadishmal