Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #294 - Move validation rule implementation into library module #295

Merged
merged 12 commits into from Nov 1, 2017

Conversation

@barbeau
Copy link
Member

commented Oct 13, 2017

Please do not merge - WIP

TODO:

  • Move main project in root to submodule gtfs-realtime-validator-webapp, and create core parent pom.xml in root directory
  • Test - alot!

Project is now broken up into two submodules:

  • gtfs-realtime-validator-lib - All core validation classes and the batch processor
  • gtfs-realtime-validator-webapp - Web server and web client. Uses the gtfs-realtime-validator-lib as a dependency.

@barbeau barbeau added this to the v1.0 milestone Oct 13, 2017

barbeau added 10 commits Oct 13, 2017
Initial work towards library submodule
* All core validation classes are moved to gtfs-realtime-validator-lib

TODO:
* Move main project in root to submodule gtfs-realtime-validator-webapp, and create core parent pom.xml in root directory
* Test - alot!
Move main web server project to -webapp, create mulimodule maven build
For some reason this builds and runs in IntelliJ, but not from Maven command line.

TODO:
* Fix maven build from command line
Remove output of batch process unit test
* This file should be generated dynamically during the unit tests and therefore shouldn't be under version control
* Add file to .gitignore to ban it from version control
Refactor Protobuf utility class to webapp
* It's not used in library
Refactor GtfsMetadata into validation package
* This is a better place for it to live, as it directly supports validation
Remove batch command line option from webapp
* This really doesn't make sense, as you can just run the -lib project directly.  Plus you can't just pass through command-line options if they aren't recognized in the -webapp project.
Move documentation to better describe project and shorten main README
* Moves the batch validation info into the gtfs-realtime-validator-lib README
* Make main README focus on building webapp project, but link to batch validator in a few places
* Move main config options into new "CONFIG" file

@barbeau barbeau changed the title WIP - Fix #294 - Move validation rule implementation into library module Fix #294 - Move validation rule implementation into library module Nov 1, 2017

@barbeau barbeau added enhancement and removed work in progress labels Nov 1, 2017

@barbeau barbeau force-pushed the use-library branch from 5b62928 to 2605c73 Nov 1, 2017

@barbeau barbeau merged commit ee8fbc7 into master Nov 1, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@barbeau barbeau deleted the use-library branch Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.