Add compatibility with Microsoft SQL Server #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Suryakandukoori! I'll take a look at this and see if I can set it up, and make it compatible with HSQLDB too. I appreciate it! |
barbeau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As mentioned in #308, when we try to deploy the validator as-is as a hosted service the default embedded HSQLDB database performance degrades with usage to the point that is it not usable. To fix this, we need to deploy a different database server (e.g., MySQL, Microsoft SQL Server, PostgreSQL).
This PR changes some of the SQL statements to make the validator compatible with Microsoft SQL server.
It needs to be tested on HSQLDB, Microsoft SQL server, and preferably other database servers as well before it is merged.
Closes #308.