Security: more trimmed/mapped chars in user names #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi @jpgill86
I have a tweak to the security patch that you merged last week. It blocks additional characters that I found are mapped or stripped from user names. The regexes are based on upstream MediaWiki code.
https://github.com/wikimedia/mediawiki/blob/master/includes/title/MediaWikiTitleCodec.php#L314-L328
I also wrote code to reject user names with invalid Unicode, and to not show a stack trace if MediaWiki itself rejects a user name.
I tested these changes on two wikis. Is this something that you are willing to review and merge?
Thanks, : )
Andrew