Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not supporting submenus ? #89

Closed
razvanioan opened this issue Oct 23, 2014 · 3 comments
Closed

Why not supporting submenus ? #89

razvanioan opened this issue Oct 23, 2014 · 3 comments

Comments

@razvanioan
Copy link

I see that Bootstrap doesn't support submenus in v3 anymore, but what if we want it ?
Here's a demo of working submenus in v3 (with extra CSS): http://www.bootply.com/92442

With that one and your plugin, hovering on a menu-item on second level which has submenu, just closes the active dropdown (even without data-close-others="true" on it).

So, I'll have to:

  • drop submenus support for my client's site (who might make them mandatory)
  • drop hover support (which I would have preffered, loved Superfish quite a lot)
  • tweak them myself to find a proper solution to keep both;

Regards

@CWSpear
Copy link
Collaborator

CWSpear commented Oct 23, 2014

For the same reason the Bootstrap team dropped them.

I haven't seen anyone using submenus in meaningful ways and the code necessary to make them work well is just too much overhead to justify this. It would be much to work to maintain the million little edge cases and stuff.

In addition, submenus just don't have much of a place on the web right now, especially the mobile web. I don't think dropdowns at all have much place on the web 99% of the time.

If you want it or feel like you have to have it or else have a specific use-case that you want to support, you're welcome to fork and implement it yourself.

@CWSpear CWSpear closed this as completed Oct 23, 2014
@razvanioan
Copy link
Author

I've found a simple solution by looking on your code, and maybe somebody else wants this.

I see that you call your plugin function on [data-hover="dropdown"], which means that if I do NOT add the data-hover attribute on my second level menu, the default behaviour of showing next level will work (on hover using CSS).

Thanks

@CWSpear
Copy link
Collaborator

CWSpear commented Oct 23, 2014

Ok, cool. Thanks for sharing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants