Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing/enabling plugins, current user and admin should get permissions #1384

Closed
netniV opened this issue Feb 21, 2018 · 3 comments
Closed

Comments

@netniV
Copy link
Member

netniV commented Feb 21, 2018

When a user is installing a plugin, they should be automatically given full rights to the plugin. Otherwise, you have to remember to go to Users, edit yourself, and THEN refresh to make sure you can see everything.

Any permission a plugin offers should be automatically ticked when either installing and/or enabling.

An alternative would be if there is a default admin group selected within settings, there could be an extra option to automatically enable that group too. That group would have to be made unavailable for deletion though to prevent issues.

@netniV netniV changed the title When enabling plugin, current user should get automatic permissions When installing and/or enabling plugin, current user should get automatic permissions Feb 21, 2018
@cigamit
Copy link
Member

cigamit commented Feb 22, 2018

I thought this was left to the plugin developer, but I have no problem short circuiting.

api_plugin_register_realm($plugin, $file, $display, $admin = **false**) {}

Just that change, and all set.

@cigamit cigamit changed the title When installing and/or enabling plugin, current user should get automatic permissions When installing/enabling plugins, current user and admin should get permissions Feb 22, 2018
cigamit added a commit that referenced this issue Feb 22, 2018
When installing/enabling plugins, current user and admin should get
permissions
@cigamit
Copy link
Member

cigamit commented Feb 22, 2018

Resolved.

@cigamit
Copy link
Member

cigamit commented Feb 22, 2018

Making too many mistakes. This global development stuff is working when you are real agile.

@cigamit cigamit closed this as completed Feb 22, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants