Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During Automation logging, include the Rule ID that triggers the creation of an item #2726

Merged
merged 4 commits into from
Jun 9, 2019
Merged

During Automation logging, include the Rule ID that triggers the creation of an item #2726

merged 4 commits into from
Jun 9, 2019

Conversation

xmacan
Copy link
Member

@xmacan xmacan commented Jun 9, 2019

Hi,
it only adds rule name:
2019/06/09 15:51:22 - AUTOM8 NOTE: Graph Added - Device[114], Graph[23079], DS[24407, 24407]
2019/06/09 15:52:50 - AUTOM8 NOTE: Graph Added - Device[114], Graph[23080], DS[24408, 24408], Rule[Win network]

It is very useful for me. I have a lot of automation graph rules and sometimes Cacti creates more graphs than I expected. With rule name in message I see problem rule and I don't need debugging.

lib/api_automation.php Outdated Show resolved Hide resolved
@netniV
Copy link
Member

netniV commented Jun 9, 2019

I’ve made a comment on two changes that should occur for this to be merged.

@netniV netniV changed the title Automation - modify Graph added message - add rule name Record rule used during automation and provide link when viewed via clog Jun 9, 2019
Copy link
Member

@netniV netniV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the CHANGELOG to add the pull request title as an entry

@netniV netniV merged commit 63cde63 into Cacti:develop Jun 9, 2019
@xmacan xmacan deleted the automation-add-rule-name branch June 13, 2019 16:52
@netniV netniV changed the title Record rule used during automation and provide link when viewed via clog During Automation logging, include the Rule ID that triggers the creation of an item Jul 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants