Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When searching for LDAP accounts, allow recursive searching #3322

Merged
merged 7 commits into from
Mar 8, 2020

Conversation

PVi1
Copy link
Contributor

@PVi1 PVi1 commented Mar 4, 2020

fixed bug on login page and added support for nested groups searching in AD.

Copy link
Member

@netniV netniV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks promising. However, I think this should really go into 1.3 as we should also be allowing people the option of whether to enable nested groups or not. Currently, this would change functionality from the expected behaviour.

Also, we should have a CHANGELOG entry for the update.

auth_login.php Outdated Show resolved Hide resolved
lib/ldap.php Outdated Show resolved Hide resolved
lib/ldap.php Outdated Show resolved Hide resolved
lib/ldap.php Outdated Show resolved Hide resolved
@cigamit
Copy link
Member

cigamit commented Mar 8, 2020

Okay, I've gone ahead and made the minor changes. I'm going to merge, but the question of the general applicability of that search we should get an answer to.

@cigamit cigamit changed the title 1.2.x Resolve issue encountered if the Preferred Realm has not been preset and add additional group search check Mar 8, 2020
@cigamit cigamit merged commit 1ebe610 into Cacti:1.2.x Mar 8, 2020
@cigamit
Copy link
Member

cigamit commented Mar 8, 2020

I'm going to add the changelog separately.

cigamit added a commit that referenced this pull request Mar 8, 2020
Adding changelog entry for: Resolve issue encountered if the Preferred Realm has not been preset and add additional group search check
@netniV
Copy link
Member

netniV commented Mar 8, 2020

I still feel that this expands the scope of searches beyond what people may expect currently therefore allowing greater access from accounts that previously did not have them.

@netniV netniV changed the title Resolve issue encountered if the Preferred Realm has not been preset and add additional group search check When searching for LDAP accounts, allow recursive searching Apr 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants