Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to hide the Graph Drilldown icons #3923

Merged
merged 11 commits into from Nov 20, 2020
Merged

Add ability to hide the Graph Drilldown icons #3923

merged 11 commits into from Nov 20, 2020

Conversation

MarcBanyard
Copy link
Contributor

The icons are on the right hand side of the graphs and the default behaviour is to display them unless you hide them per user in the permissions tab.

Hides these icons to the right of graphs
image

To hide them navigate to Configuration > Users
Select the required user and click the Permissions Tab
Under the Normal User section you will see a Hide Graph Drilldown option enable this to hide all of the graphs drilldown icons.
image

MarcBanyard and others added 8 commits October 9, 2020 19:14
Make it more obvious that a slider is disabled.
Make it more obvious that a radio slider is disabled.
Fixed the default value for the 30 second polling and amended the default values for the 1 minute polling for new installs
Bringing for up to date
… and graph.php pages

The icons are on the right hand side of the graphs and the default behaviour is to display them unless you hide them per user in the permissions tab
@TheWitness
Copy link
Member

Okay, there are problems with this merge. Cacti reserves realms above 100 for plugins. So, 'base' Cacti realms must be between 1 and 100.

So, pick another number other than 2000. I would say, just go sequentially above the current highest base realm. Can you make that change? After you have done so, I'm okay with this minor enhancement.

@TheWitness
Copy link
Member

Funny, just looking at realm 1043 is out there. Well, that'll have to be fixed at one point. Either way, let's keep everything to spec.

@MarcBanyard
Copy link
Contributor Author

Realm 26 looks like it is the last one, are you OK with this using 27?

@TheWitness
Copy link
Member

Yea, 27 should be okay. Just having a conversation with @netniV on the default value. We don't want a bunch of users opening tickets that the graph icons disappeared.

@TheWitness
Copy link
Member

Add a few spaces in the $realms array to properly align the => after 27. I know it seems trivial, but ;)

@MarcBanyard
Copy link
Contributor Author

It won't change the default behaviour, its an option to hide them if required

@TheWitness
Copy link
Member

and Drilldown should be plural "Drilldowns". Lastly, I think, instead of "feature:", add this ticket # to it. So, "feature#3923: blah".

@TheWitness
Copy link
Member

Okay, looks good. Thanks for your help.

@TheWitness TheWitness merged commit 997f1f9 into Cacti:1.2.x Nov 20, 2020
@netniV netniV changed the title Add ability to Hide the Graph Drilldown icons from the graph_view.php and graph.php pages Add ability to hide the Graph Drilldown icons from the graph_view.php and graph.php pages Nov 30, 2020
@netniV netniV changed the title Add ability to hide the Graph Drilldown icons from the graph_view.php and graph.php pages Add ability to hide the Graph Drilldown icons Nov 30, 2020
@TheWitness
Copy link
Member

@datatecuk, please note we will change the behavior in 1.2.17.

#4033

@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants