Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issues running under PHP 8.x #4383

Merged
merged 2 commits into from Aug 29, 2021
Merged

Conversation

GregOriol
Copy link
Contributor

Following request on #4376 (#4376 (comment)), this PR fixes some php 8.0 issues with error callbacks on branch 1.2.x

Copy link
Member

@netniV netniV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for updating it to 1.2.x. More and more people are likely to be using it under 1.2 so we will no doubt have other minor issues.

When you rebased / repatched, you left out the changelog again so if you could get that updated with the originally bug tracker number (mot the PR) we will go ahead an commit it as the rest looks good.

Thanks for the work 😃

@GregOriol
Copy link
Contributor Author

@netniV Do I create a "1.2.19" section in the changelog?

@netniV
Copy link
Member

netniV commented Aug 29, 2021

You just type it in 😃

However, that should already exist. You may need a pull and rebase pick it up

@GregOriol
Copy link
Contributor Author

Great! I think it should be good now :-)

@TheWitness
Copy link
Member

Great. Thanks for the contribution!

@TheWitness TheWitness merged commit 59d929a into Cacti:1.2.x Aug 29, 2021
@ddb4github
Copy link
Contributor

How about function db_warning_handler and ErrorHandler?

@GregOriol
Copy link
Contributor Author

@ddb4github You are right!

@netniV
Copy link
Member

netniV commented Aug 31, 2021

We probably have a few plugins that need the same love too.

@netniV netniV changed the title Fixes error callbacks for php 8.0+ on 1.2.x Correct issues running under PHP 8.x Oct 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants