Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of redunant code #4400

Closed
wants to merge 1 commit into from
Closed

Removal of redunant code #4400

wants to merge 1 commit into from

Conversation

rb83
Copy link
Contributor

@rb83 rb83 commented Sep 14, 2021

my IDE complained about utilities_view_cleaner() not being defined
anywhere. that's when I found out that this particular case branch
isn't used anywhere. out into the nullbucket it goes.

my IDE complained about `utilities_view_cleaner()` not being defined
anywhere. that's when I found out that this particular case branch
isn't used anywhere. out into the nullbucket it goes.
netniV added a commit that referenced this pull request Sep 25, 2021
@netniV
Copy link
Member

netniV commented Sep 25, 2021

So this was introduced in 19394ea but that also made the link for RRD Cleaner to a separate file. I think originally it was part of the same page until it got beastly and therefore separated out and this was overlooked. Good catch.

I've applied this to the 1.2.x branch since we would want it removed there too.

@netniV netniV closed this Sep 25, 2021
@netniV netniV changed the title delete dead code in utilities.php Removal of redunant code Oct 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants