Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When upgrading from pre-1.0, tree information may not properly update #4658

Merged
merged 2 commits into from
Apr 2, 2022
Merged

When upgrading from pre-1.0, tree information may not properly update #4658

merged 2 commits into from
Apr 2, 2022

Conversation

ddb4github
Copy link
Contributor

No description provided.

@ddb4github ddb4github changed the title Cacti 1.0: Can not upgrade some graph tree node with proper parent node Lost some graph tree parent info during upgrade from pre-1.0 Mar 31, 2022
TheWitness
TheWitness approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@TheWitness TheWitness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for me.

@TheWitness
Copy link
Member

Mark, if you could merge before release, I would appreciate it.

@TheWitness
Copy link
Member

@netniV 👍

netniV
netniV requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@netniV netniV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is related to an existing issue, is there a CHANGELOG entry already? If not, one should be created.

@netniV netniV merged commit 79069f5 into Cacti:1.2.x Apr 2, 2022
@ddb4github ddb4github deleted the fix100 branch April 2, 2022 12:34
@netniV netniV changed the title Lost some graph tree parent info during upgrade from pre-1.0 When upgrading from pre-1.0, tree information may not properly update Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@netniV netniV netniV requested changes

@TheWitness TheWitness TheWitness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddb4github @TheWitness @netniV