Added Gradient Color support for AREA charts #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reopening this, I know some people are excited about it. There should be a change log entry for it. Also, is this version dependant or do all 1.4+ versions support this? |
I'm not aware of any limitiations as it doesn't use any specifc RRD tool functionality. The code is basically the same since cacti 0.8.8b and the only requirement back then was to use rrdtool > 1.0 I hope I managed to add the changelog entry in the correct place ;-) |
|
Correct. We require 1.4+ anyway. |
|
Made some minor formatting for php-doc and psr changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature to enable/disable ( global setting, under RRD tool version selection ) gradient support for AREA charts.