Skip to content

Add ability to periodically check RRDfiles for errors in batch #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Add ability to periodically check RRDfiles for errors in batch #4943

merged 3 commits into from
Oct 7, 2022

Conversation

xmacan
Copy link
Member

@xmacan xmacan commented Oct 5, 2022

rrdcheck_1
rrdcheck_2
rrdcheck_3

Tested by @bmfmancini , thank you

@TheWitness
Copy link
Member

Very good work @xmacan. I'm impressed. The one PSR comment I would like to make is that you should remove the empty lines after the following loop/logic constructs:

while
if/then/else
do
switch

I'm normally doing this:

$something = something _else;
// Always line here
if (something) {
    // No extra lines here
    so_something();
    // No extra lines here
}
// Always extra line here

I hope you get the picture. If you can do those corrections, I think it's ready to merge. Changelog? I feel silly asking :)

Copy link
Member

@TheWitness TheWitness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. CHANGELOG
  2. Remove extra whitespace as articulated in my first comment.

Great work!

@TheWitness TheWitness dismissed their stale review October 7, 2022 11:20

Looks good now

@TheWitness TheWitness merged commit c22121e into Cacti:1.2.x Oct 7, 2022
@netniV netniV changed the title Fix4639 - add rrdcheck (parallel process) Add ability to periodically check RRDfiles for errors in batch Dec 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants