Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin permissions may sometimes appear in the wrong section #5166

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

ddb4github
Copy link
Contributor

If a plugin have multiple permission under one role, most permission will be shown in Plugin Permissions section.
For example, thold permissions: Configure Thresholds, and Manage Notification Lists should be a part of General Administration, but always show Manage Notification Lists in Plugin Permissions at bottom of page.

@netniV
Copy link
Member

netniV commented Jan 15, 2023

I'm not sure on this change with out double checking it later.

@ddb4github
Copy link
Contributor Author

  • Thold/Syslog register auth-roles:
    image

  • Before fix:
    image

  • After fix:
    image

@TheWitness
Copy link
Member

Good catch @ddb4github

@TheWitness
Copy link
Member

Can you add a CHANGELOG entry and prep a pull for develop too?

@netniV netniV merged commit c85f0e0 into Cacti:1.2.x Jan 17, 2023
@ddb4github ddb4github deleted the fixrole branch January 17, 2023 03:08
TheWitness added a commit that referenced this pull request Jan 22, 2023
Porting #5166 - Plugin permission is not shown in correct role section
@netniV netniV changed the title Fixed: Plugin permission is not shown in correct role section Plugin permissions may sometimes appear in the wrong section Feb 15, 2023
@netniV netniV added this to the v1.2.24 milestone Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants