Skip to content

Add IP address to the login audit for successful logins#5772

Merged
TheWitness merged 2 commits intoCacti:1.2.xfrom
xmacan:log_add_ip
Jun 19, 2024
Merged

Add IP address to the login audit for successful logins#5772
TheWitness merged 2 commits intoCacti:1.2.xfrom
xmacan:log_add_ip

Conversation

@xmacan
Copy link
Member

@xmacan xmacan commented Jun 19, 2024

Request from the forum. I agree with that. My customers use the log analyzer and the IP address information is missing for successful logins.

If you are agree with that I will prepare the same for 1.3

@browniebraun
Copy link
Member

No concerns from my side.

@TheWitness TheWitness merged commit f1b0c30 into Cacti:1.2.x Jun 19, 2024
@bmfmancini
Copy link
Member

This is also covered in my recent changes of the audit plugin

TheWitness pushed a commit that referenced this pull request Jun 20, 2024
* log message unification - add ip address

* update
This was referenced Jun 21, 2024
@ddb4github
Copy link
Contributor

Totally, Cacti 1.3.x have 34 LOGIN logs.
This issue/PR append IP Address for 8 of 33 logs.
Was other 25 logs deprecated for audit? or non-one care others?

Thanks.

@xmacan
Copy link
Member Author

xmacan commented Aug 12, 2024

@ddb4github thank you for reporting. It was quick fix, it seems that I overlooked it. I will revise it soon

@netniV netniV changed the title login log messages unification - add ip address Add IP address to the login audit for successful logins Sep 29, 2024
@xmacan xmacan deleted the log_add_ip branch October 23, 2024 18:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments