Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated VS Code extension instructions #1289

Closed
wants to merge 2 commits into from

Conversation

barnabywalters
Copy link

  • Removed link to roipoussiere extension, warned against it.
  • Added link to OCP CAD Viewer, with explanation that it handles cadquery installation itself

* Removed link to roipoussiere extension, warned against it.
* Added link to OCP CAD Viewer, with explanation that it handles cadquery installation itself
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1289 (345a3f3) into master (2d35517) will not change coverage.
The diff coverage is n/a.

❗ Current head 345a3f3 differs from pull request most recent head b0a8b54. Consider uploading reports for the commit b0a8b54 to get more accurate results

@@           Coverage Diff           @@
##           master    #1289   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          26       26           
  Lines        5495     5495           
  Branches      932      932           
=======================================
  Hits         5179     5179           
  Misses        187      187           
  Partials      129      129           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmwright
Copy link
Member

@adam-urbanczyk @lorenzncode Any objection to merging this?

@lorenzncode
Copy link
Member

Thanks @barnabywalters for highlighting the problematic link.

Based on #1291 though the README should cover the jupyter lab support and CQ-editor interfaces. I started on #1305 as a potential solution.

@adam-urbanczyk
Copy link
Member

Handled in #1305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants