Fix plane rotation method #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peque
force-pushed
the
fix-rotate
branch
2 times, most recently
from
602fcfa to
48ee781
Compare
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 94.84% 94.86% +0.02%
==========================================
Files 18 18
Lines 4173 4190 +17
==========================================
+ Hits 3958 3975 +17
Misses 215 215
Continue to review full report at Codecov.
|
jmwright
approved these changes
Dec 12, 2019
Member
|
@adam-urbanczyk Are you ok with me merging this? |
adam-urbanczyk
approved these changes
Dec 14, 2019
Member
|
Yes @jmwright , looks good to me. |
Member
|
@Peque It looks like we have a merge conflict now. Can you take a look please? As soon as that's taken care of I'll merge it. |
The vector defining the rotation is expected to be in local coordinates and therefore needs to be converted to world coordinates before applying the rotation.
Contributor
Author
|
@jmwright Rebased against upstream. 👍 😊 |
Member
|
@Peque Thanks for the contribution. |
This was referenced Dec 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vector defining the rotation is expected to be in local coordinates
and therefore needs to be converted to world coordinates before applying
the rotation.
Closes #233.