-
Notifications
You must be signed in to change notification settings - Fork 391
Use pytest to run the test suite #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Peque Thanks for the contributions. The CI systems are complaining about pytest not being installed. I think you'll need to add a pip install line to appveyor.yml and .travis.yml to get those checks to pass. |
|
@jmwright You are right! I assumed both Travis and AppVeyor would create the Conda environments with the I will fix that. 👍 |
|
Had a quick look to try to use
|
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 94.86% 94.84% -0.02%
==========================================
Files 19 18 -1
Lines 4189 4173 -16
==========================================
- Hits 3974 3958 -16
Misses 215 215
Continue to review full report at Codecov.
|
|
Thanks for the contribution @Peque . Py-test is definitely nicer. Are there any actions required regarding appveyor? BTW there are ways to do sed-like stuff with PowerShell or CMake. |
|
@adam-urbanczyk What do you mean by "any actions required regarding appveyor"? I already updated the configuration file (and pipelines are passing). Yeah, I guessed there would be ways, but I was not willing to spend time on that. 😇 I created this issue, which I think would be the most convenient way to do it: conda/conda#9506 |
|
@Peque Looks much nicer, thanks. That will be a nice quality of life improvement for all CadQuery contributors. @adam-urbanczyk I'm all for merging when you're ready. |
|
@Peque ok, clear. I just wasn't sure if you were done with it. Thanks for the contribution! |
While creating the test for #235, I missed a couple of things about
pytest:But specially, I had to write:
Instead of (
from pytest import approx):The latter is definitely shorter, clearer and more Pythonic. 😊
Also, I think nowadays
pytestis the de facto tool. Or that is my impression.Hope you like the shift.