-
Notifications
You must be signed in to change notification settings - Fork 391
Implementation of BRepOffsetAPI_MakeFilling #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of BRepOffsetAPI_MakeFilling #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 18 18
Lines 4378 4378
=======================================
Hits 4162 4162
Misses 216 216 Continue to review full report at Codecov.
|
Enable pushpoints() use
Enable pushpoints() use
PEP8 formatting
PEP8 formatting
PEP8 formatting
Black formatting
Black formatting
Black formatting
Black formatting
|
@adam-urbanczyk good idea, I will make a separate PR for Regarding the As you suggested I have also set |
|
From my side I would say that this is ready to be merged. I think I addressed all the issues,or is there something missing? |
|
@adam-urbanczyk Any objections to me merging this now? |
|
This is quite big PR (thanks for the work @bragostin !) so give me a day or two to take a final look @jmwright . |
|
Thanks again for this PR @bragostin ! |
|
@adam-urbanczyk, my pleasure, thank you for taking the time to check the code! |
This is an implementation of the OCC function
BRepOffsetAPI_MakeFillinginto CadQuery in order to produce a plate surface with a thickness (optional), enclosed by edge points, polylines or splines, and going through interpolation points (optional) .