Skip to content

Conversation

@bragostin
Copy link
Contributor

This is an implementation of the OCC function BRepOffsetAPI_MakeFilling into CadQuery in order to produce a plate surface with a thickness (optional), enclosed by edge points, polylines or splines, and going through interpolation points (optional) .

@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #253 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files          18       18           
  Lines        4378     4378           
=======================================
  Hits         4162     4162           
  Misses        216      216           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9708554...9708554. Read the comment docs.

@bragostin bragostin reopened this Dec 26, 2019
@bragostin
Copy link
Contributor Author

@adam-urbanczyk good idea, I will make a separate PR for thicken since it should work for any 2D surface actually, not only those from interpPlate

Regarding the pushpoints issue, it works fine if combine=False. So for the time being I have set the default value at False in the interpPlate function. I have added a short info about that in the docstring also. Is that ok?

As you suggested I have also set thickness=0 in the interpPlate function.

@bragostin
Copy link
Contributor Author

From my side I would say that this is ready to be merged. I think I addressed all the issues,or is there something missing?

@jmwright
Copy link
Member

jmwright commented Mar 2, 2020

@adam-urbanczyk Any objections to me merging this now?

@adam-urbanczyk
Copy link
Member

This is quite big PR (thanks for the work @bragostin !) so give me a day or two to take a final look @jmwright .

@adam-urbanczyk adam-urbanczyk merged commit cd66589 into CadQuery:master Mar 5, 2020
@adam-urbanczyk
Copy link
Member

Thanks again for this PR @bragostin !

@bragostin bragostin deleted the BRepOffsetAPI_MakeFilling branch March 5, 2020 21:17
@bragostin
Copy link
Contributor Author

@adam-urbanczyk, my pleasure, thank you for taking the time to check the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants