Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix fix #311

Merged
merged 3 commits into from
Apr 4, 2020
Merged

Helix fix #311

merged 3 commits into from
Apr 4, 2020

Conversation

adam-urbanczyk
Copy link
Member

Will resolve #271

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #311 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   95.26%   95.27%           
=======================================
  Files          18       18           
  Lines        4629     4636    +7     
=======================================
+ Hits         4410     4417    +7     
  Misses        219      219           
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 90.68% <100.00%> (ø)
tests/test_cadquery.py 99.19% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63dc39...a1e0184. Read the comment docs.

@adam-urbanczyk
Copy link
Member Author

Good for merging, simple fix but maybe take a quick look at this @jmwright .

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging. Thanks @adam-urbanczyk

@jmwright jmwright merged commit 8062b10 into master Apr 4, 2020
@jmwright jmwright mentioned this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helix seems to fail
2 participants