Skip to content

Script to create new projects v2 (old in PR #19) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 15, 2020
Merged

Script to create new projects v2 (old in PR #19) #35

merged 6 commits into from
May 15, 2020

Conversation

@Cadene
Copy link
Owner

@Cadene Cadene commented May 10, 2020

From Issue #17 and Pull Request #19.

I couldn't push to PR #19.

@jbegaint jbegaint requested a review from MicaelCarvalho May 10, 2020 23:45
@Cadene Cadene requested a review from jbegaint May 10, 2020 23:45
@Cadene
Copy link
Owner Author

Cadene commented May 10, 2020

Thanks @Ricocotam :D

@Ricocotam
Copy link
Collaborator

Ricocotam commented May 13, 2020

Thanks @Cadene :D
Nice improvement, we now have a runnable project. If any objection I agree on merging, I'll do it by 2 days if everyone agrees

jbegaint
jbegaint approved these changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@jbegaint jbegaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@Ricocotam Ricocotam merged commit 4cd68ff into master May 15, 2020
@Ricocotam Ricocotam mentioned this pull request May 15, 2020
Closed
@MicaelCarvalho
Copy link
Collaborator

MicaelCarvalho commented May 17, 2020

This PR broke master and all tests... Please be more careful and make sure tests pass before merging ;)

@MicaelCarvalho MicaelCarvalho mentioned this pull request May 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbegaint jbegaint jbegaint approved these changes

@MicaelCarvalho MicaelCarvalho Awaiting requested review from MicaelCarvalho

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Cadene @Ricocotam @MicaelCarvalho @jbegaint