Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Field/MethodSignature constructors #4

merged 1 commit into from Aug 29, 2018


Copy link

Minecrell commented Aug 29, 2018

Right now they are rather confusing in my opinion. MethodDescriptor uses of for the method that does additional parsing, but FieldSignature and MethodSignature have it directly in their constructor.

I think having it in Field/MethodSignature.of as well makes it more clear that additional parsing is done there. I've also added MethodSignature.of(String nameAndDescriptor) which accepts a concatenated method name and descriptor (e.g. isChunkLoaded(IIZ)Z)

@jamierocks jamierocks merged commit b147c6b into CadixDev:develop Aug 29, 2018
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.