Patches contain user specific version

[LexManos]

The last line of each patch is the user specific git executable version number.
Not a big issue, just a reminder mainly as it's change spam in patch updates.

[stephan-gh]

If someone wants to implement this my suggestion would be to use options like introduced in PaperMC/Paper#2324:

Add --zero-commit --full-index --no-signature to git format-patch
to reduce the diff when doing minor changes in patches.

 --zero-commit: Print 00000000... commit hash in first "From" line
   of the patch. This commit hash is useless because it changes
   every time the patch is applied.

 --full-index: Print full SHA-1 hash on "index aaaa..bbbb" lines.
   This makes the lines much longer, but avoids random changes to
   add/remove a character based on the number of objects that exist
   in the local repository.

 --no-signature: Omit Git version from generated patches.

I suspect it should be simple to add them here:

gitpatcher/src/main/groovy/net/minecrell/gitpatcher/task/patch/MakePatchesTask.groovy

Line 75 in f05f212

git.format_patch('--no-stat', '-N', '-o', patchDir.absolutePath, 'origin/upstream') >> null

[jamierocks]

Alright I've put together 2810723 to resolve this, which would look something like:

patches {
    submodule = 'upstream'
    target = file('target')
    patches = file('patches')

    zeroCommit = true
    fullIndex = true
    noSignature = true
}

Though as I'm writing this comment I think allowing users to use any extra arguments they like may be the better solution, so I would be open to implementing the following

patches {
    submodule = 'upstream'
    target = file('target')
    patches = file('patches')

    extraArgs = ['--zero-commit', '--full-index', '--no-signature']
}

I'm leaning towards the latter right now, but would love some input on it :)

edit: another discussion to have is about defaults.

[jamierocks]

Okay, so I discussed this with @Minecrell and using the second option (control over the exact arguments used), we've set the default formatPatchArgs to ['--no-stat', '-N'] (which we previously applied).

This can be expanded upon like the following:

patches {
    submodule = 'upstream'
    target = file('target')
    patches = file('patches')

    formatPatchArgs += ['--zero-commit', '--full-index', '--no-signature']
}