Skip to content

BufferBuilder optimizations should be conditionally applied #2240

@jellysquid3

Description

@jellysquid3

Some mods appear to modify vertex formats to contain multiple attributes with the same semantic element (see #2218). While there is a potential way to make our implementation compatible, it adds complexity and likely makes things slower. Given that the overhead of the VertexConsumer interface is critical, and that mods doing this are very rare, we should instead opt to just not apply the optimizations if weirdness is encountered.

This can be achieved by changing the VertexConsumerProvider to return a specialized VertexConsumer with our optimized intrinsics, when the vertex format does not contain multiple attributes with the same semantic element.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-modsArea: Mod compatibilityT-enhancementType: Enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions