Mark sprites rendered through vanilla block model renderer as active #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellysquid3
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sodium already includes an intrinsic code path for the simpler
BlockModelRenderer#rendermethod (the one which only loops over the quads and pipes them to a VertexConsumer), and that marks animated sprites as active. However, mods can call the otherBlockModelRenderer#rendermethod (the one which applies smooth lighting if needed) during immediate-mode rendering, and currently sprites rendered there are not detected. This PR fixes that.Thanks to @19PHOBOSS98 for reporting this and noticing the second code path in
BlockModelRenderer.