Avoid shader compiler warnings #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this recently when looking at the source, seems like an easy thing to fix. |
embeddedt
referenced
this pull request
in FiniteReality/embeddium
Jan 28, 2024
Fixes a compiler shader warning on some platforms. And is more hygienic.
IMS212
pushed a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
…eineMC#2271) Fixes a compiler shader warning on some platforms. And is more hygienic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually it prints the following warnings to the console:
This might not happen on all systems due to differences in drivers, but on macOS it always does this when loading or reloading a world. Not declaring this out variable avoids the shader compiler warning by only adding it if the fragment shader is actually going to read it.