New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SML style datatype declarations from grammar #613

Merged
merged 5 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@mn200
Copy link
Contributor

mn200 commented Jan 30, 2019

Now Haskell style declarations, e.g.,

datatype 'a list = Nil | Cons 'a ('a list)

(only) must be used. This also affects exception declarations, e.g.,

exception Foo string (int -> bool)

Closes #611

Remove SML style datatype declarations from grammar
Now Haskell style declarations, e.g.,

   datatype 'a list = Nil | Cons 'a ('a list)

(only) must be used.  This also affects exception declarations, e.g.,

   exception Foo string (int -> bool)

Closes #611
@myreen

This comment has been minimized.

Copy link
Contributor

myreen commented Jan 31, 2019

It seems that the CakeML code in the benchmarks directory has not been updated:

datatype 'a sptree_spt = Bs of 'a sptree_spt * 'a * 'a sptree_spt
| Bn of 'a sptree_spt * 'a sptree_spt
| Ls of 'a
| Ln;

As a result, the current regression test run should fail shortly after the sexp bootstrap. I view the current regression test as a test of the benchmark compilation step in the build sequence.

@xrchz xrchz merged commit 0b669f7 into master Feb 4, 2019

1 check was pending

cakeml-regression-test regression test in progress
Details

@xrchz xrchz deleted the gh611 branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment