Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
put name formatting logic in its own method
  • Loading branch information
Francesco Mari committed Dec 6, 2012
1 parent 4e37cdc commit 3a02b8d
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions src/main/java/org/junit/runners/Parameterized.java
Expand Up @@ -165,16 +165,13 @@ public class Parameterized extends Suite {
protected class TestClassRunnerForParameters extends BlockJUnit4ClassRunner {
private final Object[] fParameters;

private final String fPattern;

private final int fIndex;
private String fName;

protected TestClassRunnerForParameters(Class<?> type, String pattern, int index, Object[] parameters) throws InitializationError {
super(type);

fPattern = pattern;
fIndex = index;
fParameters = parameters;
fName = nameFor(pattern, index, parameters);
}

@Override
Expand Down Expand Up @@ -213,11 +210,15 @@ private Object createTestUsingFieldInjection() throws Exception {
return testClassInstance;
}

protected String nameFor(String pattern, int index, Object[] parameters) {
String finalPattern = pattern.replaceAll("\\{index\\}", Integer.toString(index));
String name = MessageFormat.format(finalPattern, parameters);
return "[" + name + "]";
}

@Override
protected String getName() {
String finalPattern = fPattern.replaceAll("\\{index\\}", Integer.toString(fIndex));
String name = MessageFormat.format(finalPattern, fParameters);
return "[" + name + "]";
return fName;
}

@Override
Expand Down

0 comments on commit 3a02b8d

Please sign in to comment.