Make the documentation year reproducible #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] I noticed that fluids could not be built reproducibly. This is due to the documentation automatically including the current year in a copyright footer, which means that the build will change depending on when you build. This patch uses SOURCE_DATE_EPOCH [1] to make this "build date" configurable/pluggable. I originally filed this in Debian as bug #1004391 [2]. [0] https://reproducible-builds.org/ [1] https://reproducible-builds.org/specs/source-date-epoch/ [2] https://bugs.debian.org/1004391
|
Hello Chris, Thank you for this pull request! I think reproducible builds are awesome and will make this change in all of my other projects as well. I have made a new release of fluids, 1.0.17, with your contribution. Sincerely, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort I noticed that fluids could not be built reproducibly.
This is due to the documentation automatically including the current year in a copyright footer, which means that the build will change depending on when you build.
This pull request uses
SOURCE_DATE_EPOCHto make this "build date" configurable/pluggable.I originally filed this in Debian as bug number #1004391.