Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization on highlight color #20

Open
CaliCastle opened this Issue Nov 30, 2018 · 4 comments

Comments

2 participants
@CaliCastle
Copy link
Owner

CaliCastle commented Nov 30, 2018

✍🏻 Issue Description

There's no way to customize the highlight color of a menu action.

@lexrus

This comment has been minimized.

Copy link

lexrus commented Mar 3, 2019

+1 for this issue.
popmenu

But anyway, this lib is awesome. Thank you.

@CaliCastle

This comment has been minimized.

Copy link
Owner Author

CaliCastle commented Mar 4, 2019

@lexrus hi, thank you for choosing PopMenu and since I saw you're located in Shanghai then maybe we can resolve in Mandarin: 😄
这个黑色背景问题只存在于Xcode的Simulator模拟机,我用了真机测试并没有出现这个按住滑动的问题,我暂时不是很确定具体原因,不过推荐你试试build到真机中试试看还会不会发生此情况,如果会的话我会开个新issue去修复这个问题。
(P.S. 目前默认的highlight color是根据背景色而变的)

@CaliCastle CaliCastle added this to In progress in v2.2.0 Mar 4, 2019

@lexrus

This comment has been minimized.

Copy link

lexrus commented Mar 4, 2019

谢谢你的回复,我试一下真机。
另外,我想要把阴影的 radius 改小一些,并且让文字水平居中,好像都不可以设置?

@CaliCastle

This comment has been minimized.

Copy link
Owner Author

CaliCastle commented Mar 4, 2019

@lexrus

修改shadow radius的话暂时不支持,我已添加到to-do,感谢提议 👍 下一个版本更新

目前设置在PopMenuViewController的第263行:

fileprivate func configureContentView() {
    ...
    containerView.addShadow(offset: .init(width: 0, height: 1), opacity: 0.5, radius: 20)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.