Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #22, use customView of UIBarButtonItem instead #27

Merged
merged 1 commit into from Apr 6, 2019

Conversation

CaliCastle
Copy link
Owner

Checklist

@CaliCastle CaliCastle self-assigned this Mar 4, 2019
Copy link

@raxityo raxityo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CaliCastle, most probably you're already aware of this because the PR is still open, but unfortunately this approach won't work for system buttons because there's no API to get the frame of UIBarButtonBarItem without a customView.

Perhaps the alternative to AppStore rejection is to always use UIBarButtonBarItem with customView?

@CaliCastle
Copy link
Owner Author

@raxityo yeah I was aware of that and it's kinda the only way to accommodate usage with UIBarButtonItem, it's only possible to get the frame and position attributes using the private API without customView so I guess it makes sense to force a customView then

@CaliCastle CaliCastle merged commit cecaea9 into develop Apr 6, 2019
@CaliCastle CaliCastle deleted the hotfix/appstore-unsafe branch April 6, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants