Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #22, use customView of UIBarButtonItem instead #27

Open
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@CaliCastle
Copy link
Owner

CaliCastle commented Mar 4, 2019

Checklist

@CaliCastle CaliCastle self-assigned this Mar 4, 2019

@raxityo
Copy link

raxityo left a comment

Hi @CaliCastle, most probably you're already aware of this because the PR is still open, but unfortunately this approach won't work for system buttons because there's no API to get the frame of UIBarButtonBarItem without a customView.

Perhaps the alternative to AppStore rejection is to always use UIBarButtonBarItem with customView?

@CaliCastle

This comment has been minimized.

Copy link
Owner Author

CaliCastle commented Mar 14, 2019

@raxityo yeah I was aware of that and it's kinda the only way to accommodate usage with UIBarButtonItem, it's only possible to get the frame and position attributes using the private API without customView so I guess it makes sense to force a customView then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.