Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/present with gesture #29

Merged
merged 4 commits into from Apr 6, 2019

Conversation

Projects
2 participants
@raxityo
Copy link

raxityo commented Mar 13, 2019

Checklist

Motivation and Context

Providing SourceView is not always sufficient, especially when showing the PopMenu in iPad. This change adds the extension I described in this comment: #14 (comment)

PopMenu

CaliCastle and others added some commits Mar 5, 2019

@CaliCastle CaliCastle self-requested a review Mar 13, 2019

@CaliCastle CaliCastle self-assigned this Mar 13, 2019

@CaliCastle CaliCastle changed the base branch from master to develop Mar 13, 2019

@CaliCastle

This comment has been minimized.

Copy link
Owner

CaliCastle commented Mar 14, 2019

Thank you so much for contributing to PopMenu, I'm currently prepping for a trip, I'll take a look when I land in China in a few days, thanks!

@CaliCastle CaliCastle added this to In progress in v2.2.0 via automation Mar 24, 2019

@CaliCastle CaliCastle merged commit 0e616fd into CaliCastle:develop Apr 6, 2019

v2.2.0 automation moved this from In progress to Done Apr 6, 2019

@raxityo raxityo deleted the raxityo:feature/present-with-gesture branch Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.