New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnViewLoaded not called #364

Closed
lploumen opened this Issue Sep 4, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@lploumen

lploumen commented Sep 4, 2016

Following the issue #342, I wanted to bypass the OnActivate logic by using the OnViewLoaded override.
Problem is it seems it is never called.
My project has nothing special, just a button navigating to a ViewModel (which inherits from Screen) where I expected the OnViewLoaded override to be called.

@nigel-sampson

This comment has been minimized.

Show comment
Hide comment
@nigel-sampson

nigel-sampson Sep 4, 2016

Contributor

Not sure what you mean by "by the OnActivate logic", can you elaborate on what you mean here and also which platform?

Contributor

nigel-sampson commented Sep 4, 2016

Not sure what you mean by "by the OnActivate logic", can you elaborate on what you mean here and also which platform?

@lploumen

This comment has been minimized.

Show comment
Hide comment
@lploumen

lploumen Sep 5, 2016

Hi Nigel,
As you already noticed on bug #342, I have a problem with OnActivate, you provided a way to fix it but it does not work (see the thread).
As I need the OnActivate method to work, I though a workaround would be to use the OnViewLoaded override for this purpose. I though it should mimic the OnActivate method (Is it right?). Then I overrode the OnViewLoaded method in my vm but it is never called. Shouldn't it be called ?
I am using Caliburn on Xamarin Forms.
Regards,

lploumen commented Sep 5, 2016

Hi Nigel,
As you already noticed on bug #342, I have a problem with OnActivate, you provided a way to fix it but it does not work (see the thread).
As I need the OnActivate method to work, I though a workaround would be to use the OnViewLoaded override for this purpose. I though it should mimic the OnActivate method (Is it right?). Then I overrode the OnViewLoaded method in my vm but it is never called. Shouldn't it be called ?
I am using Caliburn on Xamarin Forms.
Regards,

@nigel-sampson

This comment has been minimized.

Show comment
Hide comment
@nigel-sampson

nigel-sampson Oct 2, 2016

Contributor

@lploumen with the fixes discussed in #342 can you verify whether this is still an issue?

Contributor

nigel-sampson commented Oct 2, 2016

@lploumen with the fixes discussed in #342 can you verify whether this is still an issue?

@lploumen

This comment has been minimized.

Show comment
Hide comment
@lploumen

lploumen Nov 1, 2016

Hi,
I though fixing #342 would also fix this one but it's not the case. OnViewLoaded is still not called.

lploumen commented Nov 1, 2016

Hi,
I though fixing #342 would also fix this one but it's not the case. OnViewLoaded is still not called.

@nigel-sampson

This comment has been minimized.

Show comment
Hide comment
@nigel-sampson

nigel-sampson Nov 2, 2016

Contributor

Hmm, closer look this is a separate issue. The current Android and iOS Platform Providers don't deal with Xamarin.Forms, looks like a Xamarin.Forms specific one will be need to be created.

Contributor

nigel-sampson commented Nov 2, 2016

Hmm, closer look this is a separate issue. The current Android and iOS Platform Providers don't deal with Xamarin.Forms, looks like a Xamarin.Forms specific one will be need to be created.

@nigel-sampson nigel-sampson added this to the v3.1.0 milestone Nov 2, 2016

nigel-sampson added a commit that referenced this issue Apr 30, 2017

nigel-sampson added a commit that referenced this issue Apr 30, 2017

#364 Initailise Forms App
In both Setup and Features samples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment