New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String constants as an Action Parameter failed when a comma is included #439

Closed
Raghava56 opened this Issue May 22, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@Raghava56

Raghava56 commented May 22, 2017

Hi,
i am trying to access the string in my viewmodel

<Image Source="info.png" cal:Message.Attach="[Event MouseEnter]=[Action MouseOverCallOut('By default, This will be selected')]" Margin="5,0,5,0" />

In my viewmodel

this Event not triggering

public void MouseOverCallOut(string callOutText)
{
    CallOutMsg = callOutText;
}
@nigel-sampson

This comment has been minimized.

Show comment
Hide comment
@nigel-sampson

nigel-sampson May 22, 2017

Contributor

There's some confusion between the title of the issue and the contents, is the method being called without the parameter being populated or the method not being called at all?

What platform is this happening on?

Contributor

nigel-sampson commented May 22, 2017

There's some confusion between the title of the issue and the contents, is the method being called without the parameter being populated or the method not being called at all?

What platform is this happening on?

@Raghava56

This comment has been minimized.

Show comment
Hide comment
@Raghava56

Raghava56 May 22, 2017

Without parameter method is triggered.
if i pass the parameter as string i.e, 'By default, This will be selected' method not called at all.
if i pass parameter as 'Hello' then method is triggering.

Raghava56 commented May 22, 2017

Without parameter method is triggered.
if i pass the parameter as string i.e, 'By default, This will be selected' method not called at all.
if i pass parameter as 'Hello' then method is triggering.

@Raghava56 Raghava56 changed the title from how to send a custom string as an action parameter in caliburn micro to how to send a string have comma(,) as an action parameter in caliburn micro May 22, 2017

@Raghava56 Raghava56 changed the title from how to send a string have comma(,) as an action parameter in caliburn micro to how to send a string having comma(,) as an action parameter in caliburn micro May 22, 2017

@nigel-sampson nigel-sampson added the bug label May 22, 2017

@nigel-sampson nigel-sampson added this to the v3.1.0 milestone May 22, 2017

@nigel-sampson nigel-sampson changed the title from how to send a string having comma(,) as an action parameter in caliburn micro to String constants as an Action Parameter failed when a comma is included May 22, 2017

@nigel-sampson

This comment has been minimized.

Show comment
Hide comment
@nigel-sampson

nigel-sampson May 22, 2017

Contributor

It looks like there was a bug in the string parsing that didn't take into account single quotes as being the start of a string so it was broken up into two parameters.

I've pushed a fix that should be included in the next release.

Contributor

nigel-sampson commented May 22, 2017

It looks like there was a bug in the string parsing that didn't take into account single quotes as being the start of a string so it was broken up into two parameters.

I've pushed a fix that should be included in the next release.

@Raghava56

This comment has been minimized.

Show comment
Hide comment
@Raghava56

Raghava56 May 22, 2017

hi,
it is working with interaction triggers i.e,

`<i:Interaction.Triggers>
                                                <i:EventTrigger EventName="MouseEnter">
                                                    <cal:ActionMessage MethodName="MouseOverCallOut">
                                                        <cal:Parameter Value="By enabling this option, click here."/>
                                                    </cal:ActionMessage>
                                                </i:EventTrigger>
                                            </i:Interaction.Triggers>`

Raghava56 commented May 22, 2017

hi,
it is working with interaction triggers i.e,

`<i:Interaction.Triggers>
                                                <i:EventTrigger EventName="MouseEnter">
                                                    <cal:ActionMessage MethodName="MouseOverCallOut">
                                                        <cal:Parameter Value="By enabling this option, click here."/>
                                                    </cal:ActionMessage>
                                                </i:EventTrigger>
                                            </i:Interaction.Triggers>`
@nigel-sampson

This comment has been minimized.

Show comment
Hide comment
@nigel-sampson

nigel-sampson May 22, 2017

Contributor

Yup that would work as a work around,

Contributor

nigel-sampson commented May 22, 2017

Yup that would work as a work around,

@Raghava56

This comment has been minimized.

Show comment
Hide comment
@Raghava56

Raghava56 May 22, 2017

thanks for your value information and time

Raghava56 commented May 22, 2017

thanks for your value information and time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment