New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set title of window in xaml #462

Closed
tziemek opened this Issue Jul 27, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@tziemek

tziemek commented Jul 27, 2017

Hi,
we are using CM with WPF and wondered why setting the title on a window in xaml has no effect. I found the responsible code in https://github.com/Caliburn-Micro/Caliburn.Micro/blob/master/src/Caliburn.Micro.Platform/net40/WindowManager.cs in the CreateWindow method. There is a check for the IHaveDisplayName interface and existing bindings.

My suggestion is to also do nothing if there is already a title defined, hence i don't have to set the DisplayName property in my viewmodel.

Thanks

@nigel-sampson

This comment has been minimized.

Show comment
Hide comment
@nigel-sampson

nigel-sampson Jul 28, 2017

Contributor

That makes sense, happy to take a PR for this. 😄

Contributor

nigel-sampson commented Jul 28, 2017

That makes sense, happy to take a PR for this. 😄

@nigel-sampson

This comment has been minimized.

Show comment
Hide comment
@nigel-sampson

nigel-sampson Sep 11, 2017

Contributor

Resolved by #476 .

Thanks!

Contributor

nigel-sampson commented Sep 11, 2017

Resolved by #476 .

Thanks!

nigel-sampson added a commit that referenced this issue Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment