DM-12268 Fix fits image rendering problem since latest FITS library update #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robyww
approved these changes
Nov 15, 2017
| while (iter.hasNext()) { | ||
| HeaderCard card = (HeaderCard) iter.next(); | ||
| cards[i] = card.toString(); | ||
| i++; | ||
| clonedHeader.addLine(card); |
There was a problem hiding this comment.
I think we should make a copy.
clonedHeader.addLine(card.copy());
or
clonedHeader.addLine(new HeaderCard(card.getKey(), card.getValue(), card.getComment()));
ejoliet
approved these changes
Nov 15, 2017
…HeaderFrom() (FitsRead.java)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The development fixes the image rendering by changing the way to clone the fits header.
test:
go to localhost:8080/firefly
do image search on m31, WISE image, '4 band level1' and band 2.
or
do upload, image search on the following sample,
issue:
there is some issue regarding how nom.tam.fits library parses the fits header when the keyword value ending in '&' and immediately followed by 'CONTINUE' line. The string after the CONTINUE keyword is ignored if keyword 'LONGSTRN' is defined after the keyword with long string values per the parsing method of current nom.tam.fits library used, therefore the keyword value of long string case may be displayed inaccurately. (i.e. it ends with '&' and without containing the string after CONTINUE keyword).