New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A merge for Bayesian Rugby #249
A merge for Bayesian Rugby #249
Conversation
Oh my! I'll give this a looks over tonight. Thanks @springcoil! |
Any views, or do I need to change some things. No immediate rush but I'd just like to unlock the achievement as soon as possible. |
+1 :) |
@CamDavidsonPilon Is this a first whole example contributed to this project? |
I didn't get a chance to look at it last night, unfortunately. I've opened it now - is it possible to do this without pandas? It's currently not a prerequisite, and I haven't introduced any pandas yet in the book. And yes, this is the first full example! |
Hi Cam, On Wed, Mar 11, 2015 at 2:25 PM, Cameron Davidson-Pilon <
Peadar Coyle |
I would recommend introducing pandas though. I have other examples in mind and it is a core part of the PyData stack. |
Hmm, I'm not 100% sold on Pandas - but it's okay for now. Can you add a note about Pandas? Something like, "Below we use the Pandas library to manipulate the data...". And also can you remove seaborn - or the graphs 100% reliant on it? |
Hi Cam, On Wed, Mar 11, 2015 at 5:54 PM, Cameron Davidson-Pilon <
Peadar Coyle |
Seaborn isn't necessary that was just for a bit of prettiness - but your On Wed, Mar 11, 2015 at 5:58 PM, Peadar Coyle peadarcoyle@googlemail.com
Peadar Coyle |
I don't think you will need to rebase, just push to your branch |
Hi On Wed, Mar 11, 2015 at 6:11 PM, Cameron Davidson-Pilon <
Peadar Coyle |
Ok I did what I was told :) |
Looks good to me! I might make some minor edits here and there to clean up the language, I hope you don't mind. Anyways, mergin! |
A merge for Bayesian Rugby
No problem. I don't object to minor edits you are the editor! On Wednesday, March 11, 2015, Cameron Davidson-Pilon <
Peadar Coyle |
A little Bayesian Rugby example