Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A merge for Bayesian Rugby #249

Merged
merged 2 commits into from Mar 11, 2015
Merged

A merge for Bayesian Rugby #249

merged 2 commits into from Mar 11, 2015

Conversation

springcoil
Copy link
Contributor

A little Bayesian Rugby example

@CamDavidsonPilon
Copy link
Owner

Oh my! I'll give this a looks over tonight. Thanks @springcoil!

@springcoil
Copy link
Contributor Author

Any views, or do I need to change some things. No immediate rush but I'd just like to unlock the achievement as soon as possible.

@syzer
Copy link

syzer commented Mar 11, 2015

+1 :)

@springcoil
Copy link
Contributor Author

@CamDavidsonPilon Is this a first whole example contributed to this project?

@CamDavidsonPilon
Copy link
Owner

I didn't get a chance to look at it last night, unfortunately. I've opened it now - is it possible to do this without pandas? It's currently not a prerequisite, and I haven't introduced any pandas yet in the book. And yes, this is the first full example!

@springcoil
Copy link
Contributor Author

Hi Cam,
Given the nature of the tabular data I think Pandas is the easiest way to
use it. It isn't actually needed for the PyMC based model.

On Wed, Mar 11, 2015 at 2:25 PM, Cameron Davidson-Pilon <
notifications@github.com> wrote:

I didn't get a chance to look at it last night, unfortunately. I've opened
it now - is it possible to do this without pandas? It's currently not a
prerequisite, and I haven't introduced any pandas yet in the book. And yes,
this is the first full example!


Reply to this email directly or view it on GitHub
#249 (comment)
.

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

@springcoil
Copy link
Contributor Author

I would recommend introducing pandas though. I have other examples in mind and it is a core part of the PyData stack.

@CamDavidsonPilon
Copy link
Owner

Hmm, I'm not 100% sold on Pandas - but it's okay for now. Can you add a note about Pandas? Something like, "Below we use the Pandas library to manipulate the data...". And also can you remove seaborn - or the graphs 100% reliant on it?

@springcoil
Copy link
Contributor Author

Hi Cam,
I will when I head home.
Do I need to rebase to make these changes?

On Wed, Mar 11, 2015 at 5:54 PM, Cameron Davidson-Pilon <
notifications@github.com> wrote:

Hmm, I'm not 100% sold on Pandas - but it's okay for now. Can you add a
note about Pandas? Something like, "Below we use the Pandas library to
manipulate the data...". And also can you remove seaborn - or the graphs
100% reliant on it?


Reply to this email directly or view it on GitHub
#249 (comment)
.

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

@springcoil
Copy link
Contributor Author

Seaborn isn't necessary that was just for a bit of prettiness - but your
graphs are pretty enough

On Wed, Mar 11, 2015 at 5:58 PM, Peadar Coyle peadarcoyle@googlemail.com
wrote:

Hi Cam,
I will when I head home.
Do I need to rebase to make these changes?

On Wed, Mar 11, 2015 at 5:54 PM, Cameron Davidson-Pilon <
notifications@github.com> wrote:

Hmm, I'm not 100% sold on Pandas - but it's okay for now. Can you add a
note about Pandas? Something like, "Below we use the Pandas library to
manipulate the data...". And also can you remove seaborn - or the graphs
100% reliant on it?


Reply to this email directly or view it on GitHub
#249 (comment)
.

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

@CamDavidsonPilon
Copy link
Owner

I don't think you will need to rebase, just push to your branch BayesianRugby and it will appear here.

@springcoil
Copy link
Contributor Author

Hi
No problem :)

On Wed, Mar 11, 2015 at 6:11 PM, Cameron Davidson-Pilon <
notifications@github.com> wrote:

I don't think you will need to rebase, just push to your branch
BayesianRugby and it will appear here.


Reply to this email directly or view it on GitHub
#249 (comment)
.

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

@springcoil
Copy link
Contributor Author

Ok I did what I was told :)

@CamDavidsonPilon
Copy link
Owner

Looks good to me! I might make some minor edits here and there to clean up the language, I hope you don't mind. Anyways, mergin!

CamDavidsonPilon added a commit that referenced this pull request Mar 11, 2015
@CamDavidsonPilon CamDavidsonPilon merged commit c5731a5 into CamDavidsonPilon:master Mar 11, 2015
@springcoil
Copy link
Contributor Author

No problem. I don't object to minor edits you are the editor!

On Wednesday, March 11, 2015, Cameron Davidson-Pilon <
notifications@github.com> wrote:

Merged #249
#249
.


Reply to this email directly or view it on GitHub
#249 (comment)
.

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants