fix Firefox issue #63

Closed
CamDavidsonPilon opened this Issue Jun 4, 2013 · 9 comments

Projects

None yet

2 participants

@CamDavidsonPilon

The custom css styling for the book, in styles/custom.css do not play well with Firefox. I'd like to fix this asap.

@KartikTalwar

Temporary fix:

.cell { width:800px; margin-left:180px !important; }

Let me know if this works

@CamDavidsonPilon

@kartikTalwar
this works, but I'm worried about hardcoding 180px. Any particular reason 180?

@CamDavidsonPilon

what are your thoughts on:

    div.cell{
       width:60%;
       margin-left:20% !important;
       margin-right:auto;
    }

this seems to work. Can you see any edge cases that might break it?

@KartikTalwar

@CamDavidsonPilon This is weird:

54% actually shrinks the width in chrome (since the rest of the content is set to 800px) but works nicely on firefox. From just playing around with the left-margin, i found the distance of the content container and the content to be 180px (~175 but added that additional padding). Seems like to keep both browsers happy, we cant use dynamic width. Looks to me that the margin is being inherited on chrome, which is why hardcoding 180px defines the property on ff but doesnt affect chrome. This is working on both:

div.cell {
  width: 800px;
  margin-left: 16% !important;
  margin-right: auto;
}

Thoughts?

@CamDavidsonPilon

I'm happy with that. I'll make the changes now. Thanks

@KartikTalwar

Cool!

@CamDavidsonPilon CamDavidsonPilon added a commit that referenced this issue Jun 4, 2013
@CamDavidsonPilon fixing issue #63 7251ab8
@KartikTalwar

Time to close?
Protip: Having 'Fixes #63' in the commit message closes it too

@CamDavidsonPilon

so close. Yea I'm happy closing this. Thanks Kartik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment