Make res middleware reflect opposite direction #1

Merged
merged 1 commit into from Feb 1, 2013

Conversation

Projects
None yet
2 participants
@timshadel
Collaborator

timshadel commented Feb 1, 2013

prev is the natural opposite of next.

Make res middleware reflect opposite direction
`prev` is the natural opposite of `next`.
@camshaft

This comment has been minimized.

Show comment Hide comment
@camshaft

camshaft Feb 1, 2013

Owner

If you look at the code underneath, it's not going to the previous middleware though. It still gets executed in the same order as your request stack. I don't know if prev indicates that happening

Owner

camshaft commented Feb 1, 2013

If you look at the code underneath, it's not going to the previous middleware though. It still gets executed in the same order as your request stack. I don't know if prev indicates that happening

@timshadel

This comment has been minimized.

Show comment Hide comment
@timshadel

timshadel Feb 1, 2013

Collaborator

That's bad, then. All middleware needs to be reverse executed on response. Even standard connect stuff you override end, then execute this layer, then call end (executing previous layers).

Collaborator

timshadel commented Feb 1, 2013

That's bad, then. All middleware needs to be reverse executed on response. Even standard connect stuff you override end, then execute this layer, then call end (executing previous layers).

@camshaft

This comment has been minimized.

Show comment Hide comment
@camshaft

camshaft Feb 1, 2013

Owner

Make sense. I'll fix it then

Owner

camshaft commented Feb 1, 2013

Make sense. I'll fix it then

camshaft added a commit that referenced this pull request Feb 1, 2013

Merge pull request #1 from timshadel/patch-1
Make res middleware reflect opposite direction

@camshaft camshaft merged commit 1f6a5c5 into camshaft:master Feb 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment