PullRequest #175 introduced some issues in the Puppet manifest, and introduced issues in the unit tests. This commit fixes many of those issues (plus issues which were identified as a result). * Puppet now also installs Gammu-smsd and Gammu-doc. It points the CFM2 install file to the MySQL definition for Gammu, to install that as well (Puppet). * GenericObject now checks for the "old" value before simply inserting it (Unit Test). To prevent PDO locks with multiple SQL statements, it also closes cursors where required (Install script). Lastly, it checks when installing database tables that the changelog table already exists before proceeding (Install script). * Object_Userauth checks whether "old" values are set before referring to them (Install script). * Install script now only freshens the jQueryMobile libraries, not prompts (Install script) * Amended talk tests in the Limbo plugin to return the correct slot based on current logic (Unit Test) * Ensure that the sessions are saved to an appropriate place during unit testing (/tmp) - (Unit Test) * Prevent testing of OpenID from erroring due to headers already being sent messages (Unit Test, but probably not a bad idea elsewhere too?)
… there isn't any
This implements a new Object type - "ChangeLog", which stores the diff(ish) of each change, the actor who performed said change, and on which table this occurred. This Object type is instantiated by the Generic_Object function writeChangeLog() that bundles up the required fields, and creates the object. This object is then overloaded by the SecureConfig and UserAuth objects to prevent leakage of private data. This is also overloaded by the ChangeLog object to prevent it from writing its own data over and over again! To call the Generic_Object function, there is a new Plugin called, again, ChangeLog which triggers on the Create, Update and Delete actions, after the entry has been written.
As per Jack's suggestion.
* Added new "hasOverlap" boolean to Talk objects * Adds new grey triangle flag to MainScreen, and a more complete flag on the Object_Talk and Timetable screens (visible only to workers and admins on the last two screens). Object_Talk includes a hyperlink to get you to at least one of the conflicted talks (aside from this one, assuming multiple conflicts!)
* Commented out the "mirror://" format as it's down during test - change back if required. * Move from turning on AllowOverride to putting the rewrite in a new entry in /etc/apache2/conf.d * As a result of that, move cfm2 into it's own /var/www/ directory. * Add a pointer to the /var/www/cfm2 directory
* Fixed loads of glitches in the Setup script. Some pretty heavy repositioning went on there too. * Created a very basic Vagrantfile * Created a slightly more complex manifest which spins up all the services. * Added a .gitignore entry for the Vagrant support files.